kurtbrose / pyjks

a pure python Java KeyStore file parser, including private key decryption

MIT License

130 stars 35 forks source link

Pyjks doesn't convert alias to lowercase #38

Closed silvervesi closed 6 years ago

silvervesi commented 6 years ago

This is what Java Keytool does when importing items, although it's not documented everywhere. Keytool throws an error and Keystore Explorer fails silently when opening a keystore that has an alias where atleast one character is uppercase.

mahmoud commented 6 years ago

Oh, good catch, thank you! This is kind of unfortunate, as it's not documented and not strictly a format issue. Still, compatibility is the name of the game.

Sounds like it might be a small change. Since you have the setup to test, would you be able to issue a PR?

silvervesi commented 6 years ago

I'm on it.

Sv.

On 18 April 2018 at 19:33, Mahmoud Hashemi notifications@github.com wrote:

Oh, good catch, thank you! This is kind of unfortunate, as it's not documented and not strictly a format issue. Still, compatibility is the name of the game.

Sounds like it might be a small change. Since you have the setup to test, would you be able to issue a PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kurtbrose/pyjks/issues/38#issuecomment-382449282, or mute the thread https://github.com/notifications/unsubscribe-auth/AdwYXnPjkYgYNfuK649EE2A6Fis2ZBZoks5tp2rqgaJpZM4TZxnP .

silvervesi commented 6 years ago

https://github.com/kurtbrose/pyjks/pull/39

Apologies if I have overlooked something obvious. The 2 tests there are literally the first tests I've ever written.

Sv.

On 19 April 2018 at 14:27, Silver silvervesi@gmail.com wrote:

I'm on it.

Sv.

On 18 April 2018 at 19:33, Mahmoud Hashemi notifications@github.com wrote:

Oh, good catch, thank you! This is kind of unfortunate, as it's not documented and not strictly a format issue. Still, compatibility is the name of the game.

Sounds like it might be a small change. Since you have the setup to test, would you be able to issue a PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kurtbrose/pyjks/issues/38#issuecomment-382449282, or mute the thread https://github.com/notifications/unsubscribe-auth/AdwYXnPjkYgYNfuK649EE2A6Fis2ZBZoks5tp2rqgaJpZM4TZxnP .

kurtbrose commented 6 years ago

thanks! :-)

mahmoud commented 6 years ago

39 fixes this and was released today in v18.0.0. Thanks all!