search

kurtbrose / pyjks

a pure python Java KeyStore file parser, including private key decryption
MIT License
130 stars 35 forks source link

Adjusted asn1 encoder so that it doesn't include empty attributes #41

Closed magnuswatn closed 6 years ago

magnuswatn commented 6 years ago

Fixes https://github.com/kurtbrose/pyjks/issues/34

magnuswatn commented 6 years ago

Ah, seems like the tests are pinned against pyasn1 0.1.7, which doesn't support ifNotEmpty.

magnuswatn commented 6 years ago

@mahmoud What do you think? Should we require pyasn1 v0.3.2 or higher, og should I make it work with older versions?

mahmoud commented 6 years ago

So, 0.3.2 has been out for about a year, that seems pretty reasonable. I also went through the changelog line by line since 0.1.7 and didn't see anything that looked breaking for our use, so I'm OK with a requirement upgrade. A few behaviors might change for some corner-case users, but that's what the issue tracker is for. :)

Don't forget to update the requirements.txt as well as making the setup.py >= entry. Thanks!

magnuswatn commented 6 years ago

I had to go up to 0.3.5, as there was some bugs in 0.3.2, .3 and .4. It came out just shy of a year ago, hope it's ok.

I also snuck in some other small changes.

mahmoud commented 6 years ago

LGTM! Thanks! :)