search

kurtbrose / pyjks

a pure python Java KeyStore file parser, including private key decryption
MIT License
130 stars 35 forks source link

pycryptodome -> pycryptodomex; Crypto -> Cryptodome #46

Closed castrapel closed 5 years ago

castrapel commented 5 years ago

pycryptodome is designed to be a drop-in replacement for pycrypto, however in some cases, pycryptodome is not fully compatible with pycrypto. I have ran in to one of these scenarios. My service has a third-party dependency which requires pycrypto, and pycryptodome is not able to replicate the functionality that this library requires.

pycryptodomex is the same as pycryptodome, however it doesn't function as a drop-in replacement and will not replace the Crypto class. More details about this exist here: https://pycryptodome.readthedocs.io/en/latest/src/installation.html

mahmoud commented 5 years ago

Hi @castrapel! I sorta figured this day would come eventually. Sorry to hear about the pycrypto dep, but thanks to you, at least pyjks won't be a blocker for others in your sitch. Thanks for the PR!

mahmoud commented 5 years ago

It's a good night to release software :) v19.0.0 is now up on PyPI!

castrapel commented 5 years ago

Monday night is the best night for that! Thanks for the quick response!

hosseinsh commented 5 years ago

Thanks Mahmoud for the fast follow-up on this -Hossein