Update jks.py - Githubissues

kurtbrose / pyjks

a pure python Java KeyStore file parser, including private key decryption

MIT License

130 stars 35 forks source link

Update jks.py #61

Closed kuldeep-mishra closed 4 years ago

kuldeep-mishra commented 4 years ago

In python 2.7.x many issues have occured where comparison between 'JavaString' & 'str' have failed. https://github.com/kurtbrose/pyjks/issues/60, https://github.com/kurtbrose/pyjks/issues/47 type cast sealed_obj.sealAlg which is of type <class 'javaobj.v1.beans.JavaString'> to <type 'str'> So, that 'String' to 'String' comparison is performed and not 'JavaString' to 'String'

mahmoud commented 4 years ago

Seems reasonable, passes CI, looks good to me, thanks!

rmogylatov-cisco commented 3 years ago

Has this ever been released on PyPI?