Closed nitn3lav closed 2 months ago
Can you provide a rationale and example code for why you'd want to Clone
a Join
struct? My mental model is that it's owned by the queried object, and never lives elsewhere. Definitely happy to include it if it makes sense, just concerned it might also lead to mistakes where users think they're updating the values, but it was only the clone that was updated.
Please note that this will break code like this because calls to
clone
andto_owned
will no longer be dereferenced: