search

kurtomerfaruk / wicked-charts

Automatically exported from code.google.com/p/wicked-charts
0 stars 0 forks source link

Patch for /trunk/wicked-charts-highcharts/src/main/java/com/googlecode/wickedcharts/highcharts/options/Events.java #39

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
added legendItemClick event as described here: 
http://stackoverflow.com/questions/10604952/how-to-modify-highcharts-legend-item
-click-event
i'm using it in my project, and it will be nice not have to use it via 
homegrown wrapper to Event

Original issue reported on code.google.com by bartlomiej.lopatka on 11 Jul 2013 at 9:12

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks! I will include that in the next version.

Original comment by tom.homb...@gmail.com on 11 Jul 2013 at 10:03

GoogleCodeExporter commented 9 years ago 
i think, i might have some more changes - should i create one patch for one 
file in googlecode editor, or simply create patch in my local repo for all 
changes and then create an issue ?

Original comment by bartlomiej.lopatka on 11 Jul 2013 at 10:10

GoogleCodeExporter commented 9 years ago 
Both is fine with me. Do it the way you like best, I will see to include it 
then.

Thanks!

Original comment by tom.homb...@gmail.com on 11 Jul 2013 at 10:22

GoogleCodeExporter commented 9 years ago 
Ok, i've reviewed API for Legend type (i'm using some of the properties, that 
are not supported by wicked-charts) and now it has all the options from 
Highcharts Options Reference (HOR) http://api.highcharts.com/highcharts#legend
I've added 2 new classes.
Then i revieved whole HOR for events, and found some missing ones (they are 
repeatedly used in all plot types), also i've added Events type to events field 
in Axis type (I've deleted @JsonIgnore annotation and get rid of DummyObject).
Now Events type contains all type of events that are used in highcharts, but 
maybe it would be nice, to disassebmle Event to specific Events ? (but it's not 
important so much than having all properties supported)

This patch also includes changes done in Events.java.patch posted earlier!

Original comment by bartlomiej.lopatka on 11 Jul 2013 at 11:36

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by tom.homb...@gmail.com on 26 Jul 2013 at 8:21

GoogleCodeExporter commented 9 years ago 
I have added the patch for the upcoming release. Thanks!

Original comment by tom.homb...@gmail.com on 24 Nov 2013 at 9:21