kurtomerfaruk / wicked-charts

Automatically exported from code.google.com/p/wicked-charts
0 stars 0 forks source link

LiveDataSeries - not possible to have update not returning data #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a chart with a live data series
2. In LiveDataSeries update method, return null

What is the expected output? What do you see instead?

I was expecting returning null was going to not update the chart but it raises 
a NPE. It could be good to be able to skip an update occurence (because data is 
not available yet for any reason). I guess just checking for null before update 
in Wicket6LiveDataAjaxBehavior could do the trick.

What version of the product are you using? On what operating system?
1.3.1 (wicked-charts-wicket6)

Thanks !

Original issue reported on code.google.com by nicolas....@gmail.com on 6 Dec 2012 at 8:49

GoogleCodeExporter commented 9 years ago
Additionally, it could be good to set the init method of 
com.googlecode.wickedcharts.highcharts.Chart protected instead of private to 
allow easy override of ChartBehavior :-)

Original comment by nicolas....@gmail.com on 6 Dec 2012 at 9:01

GoogleCodeExporter commented 9 years ago
Interesting feature :).

I will look into it!

Original comment by tom.homb...@gmail.com on 6 Dec 2012 at 9:31

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r85.

Original comment by tom.homb...@gmail.com on 15 Dec 2012 at 10:06

GoogleCodeExporter commented 9 years ago
I added the possibility to return null for the next version.

For overriding ChartBehavior, i added the method createChartBehavior() to the 
Chart class.

Thanks for the ideas!

Original comment by tom.homb...@gmail.com on 15 Dec 2012 at 10:11