kurtosis-tech / kurtosis-testsuite-starter-pack

The Unlicense
1 stars 1 forks source link

Push files artifacts a level higher, into the testsuite itself #33

Closed mieubrisse closed 3 years ago

mieubrisse commented 3 years ago

Right now, each test declares its own files artifacts. This is weird though, because the DockerContainierInitializers (which exist at a higher level of abstraction than the tests) consume these files artifacts. This means you can get into weird situations where your DockerContainerInitializer consumes a files artifact that the test doesn't declare

mieubrisse commented 3 years ago

Problem with this: if we do this, we lose the association between test <-> files artifact. Therefore, Core on startup would need to pull all artifacts of all tests, even if I'm only running a single test (i.e., Core has no way to say "this test isn't being run so skip pulling its artifacts")

mieubrisse commented 3 years ago

Reason to do this: it would match how static files are declared

mieubrisse commented 3 years ago

Closing this, as we've now gone the other way - all files artifacts & static files are declared in the test configuration. The rationale for this is that each test gets its own enclave data volume, so each test needs to tell the API container (via the registerStaticFiles/registerFilesArtifacts endpoints) what files the test needs