kurtosis-tech / kurtosis-testsuite-starter-pack

The Unlicense
1 stars 1 forks source link

Fix the issue with Rust's borrow checker/passing services around, such that we don't create a new service struct on every `get_service` call #38

Closed mieubrisse closed 3 years ago

mieubrisse commented 3 years ago

See network_context line 143:

        // Yes, this creates a second Service interfaces; yes, this is inefficient; yes, there's probably a better way to do this
        // At this point though I'm *so* sick of fighting Rust's compiler and its un-Google-able, seemingly-draconian errors so
        // I'm doing it this way (e.g. - how can I both store a value in a hashmap, use it in the AvailabilityChecker, and return
        // it to the user??) ~ ktoday, 2021-02-12
mieubrisse commented 3 years ago

Fixed, alhamdulilah