Switch to 'exec' form of Dockerfile CMD so that users adding a debugger don't get confused about "am I in a shell?"

kurtosis-tech / kurtosis-testsuite-starter-pack

The Unlicense

1 stars 1 forks source link

Switch to 'exec' form of Dockerfile CMD so that users adding a debugger don't get confused about "am I in a shell?" #62

Closed mieubrisse closed 3 years ago

mieubrisse commented 3 years ago

The CMD form WITHOUT [ and ] is implicitly run inside sh, which means it does variable replacement. If you add the brackets, it becomes the "exec" form which is NOT implicitly run inside a shell (and won't do variable replacement or && expansion). We should make it ultra-clear to users by explicitly specifying ["sh", "-c", "the_command and some args"] so users can clearly see what's going on.

mieubrisse commented 3 years ago

Meh, not important enough to do