search

kurtosis-tech / kurtosis

A platform for packaging and launching ephemeral backend stacks with a focus on approachability for the average developer.
https://docs.kurtosistech.com/
Apache License 2.0
374 stars 53 forks source link

some logs, specifically image download logs, get printed twice in the enclave manager ui #1792

Open leeederek opened 11 months ago

leeederek commented 11 months ago

What's your CLI version?

0.85.9

Description & steps to reproduce

image

Go to enclave manager, create a package via the UI, and then watch the logs. Some log lines get printed twice, specifically the image download lines

Desired behavior

Log lines are not doubled, ever

What is the severity of this bug?

Papercut; this bug is frustrating, but I have a workaround.

What area of the product does this pertain to?

Frontend: the Graphical User Interface, including the Enclave Manager

tedim52 commented 11 months ago

For context, the behavior from the backend is expected for steps that take some time like downloading images, every few seconds it will send up update on the progress info till it's done, hence the duplicated log lines. The reason the duplicated lines dont't show in the CLI is because we have logic to detect whether an instruction has "progress info/updates" and then present a spinner/loader instead of the duplicate log messages. That logic is here.

We can either change the backend behavior or make the UI output similar to the CLI output.

tedim52 commented 11 months ago

eg. CLI looks like this at the same step without printing duplicate lines

INFO[2023-11-15T16:20:54+03:00] Uploading and executing package 'github.com/kurtosis-tech/ethereum-package' 
⣽   ████████████████████ Validating Starlark code and downloading container images - execution will begin shortly
Downloading <>/<>:stable
Downloading <>/blobscan<>indexer:master