kurtosis-tech / kurtosis

A platform for packaging and launching ephemeral backend stacks with a focus on approachability for the average developer.
https://docs.kurtosistech.com/
Apache License 2.0
384 stars 55 forks source link

Using upload_files through GitHub URL doesn't copy the exact code #2538

Open nidhi-singh02 opened 3 months ago

nidhi-singh02 commented 3 months ago

What's your CLI version?

1.1.0

Description & steps to reproduce

I am using plan.upload_files with a private GitHub URL, the code doesn't get copied as it is. I see some parts are missing, it is a solidity file.

Desired behavior

Files should get copied inside enclave as is.

What is the severity of this bug?

Critical; I am blocked and Kurtosis is unusable for me because of this bug.

What area of the product does this pertain to?

CLI: the Command Line Interface

tedim52 commented 2 months ago

Hey @nidhi-singh02 would you mind expanding on this? Could you give me an example of the github URL/how you are referencing it? Is it referencing a package (upload_files only allows referencing kurtosis packages, not arbitrary urls) Additionally, if you are referring to a private GitHub URL - are you authenticated via kurtosis github login to access that private github url?

nidhi-singh02 commented 2 months ago

Sure, unfortunately I cannot share the GitHub URL as it is private repository. Yes, I am using upload_files - I read in the documentation that it works for any GitHub URL irrespective of it being a kurtosis package. Let me know if my understanding needs correction. What I understand is whatever is being uploaded, is stored inside the enclave.

Yes, I am authenticated via kurtosis github login.

tedim52 commented 1 week ago

Hey @nidhi-singh02 let me know if you were able to solve this - I'm happy to iterate with you over Discord to see why all files aren't being copied. Feel free to send me a friend request.