search

kurtosis-tech / kurtosis

A platform for packaging and launching ephemeral backend stacks with a focus on approachability for the average developer.
https://docs.kurtosistech.com/
Apache License 2.0
384 stars 55 forks source link

"Starting validation" `StarlarkRunProgress` message has incorrect `TotalSteps` field #2595

Open MegaRedHand opened 2 weeks ago

MegaRedHand commented 2 weeks ago

What's your CLI version?

1.4.1

Description & steps to reproduce

When running a Starlark package via the SDK's RunStarlarkPackage (or its remote counterpart), I'm fetching the response from the channel and formatting them manually for printing. When reaching the "Starting validation" message we can see the total steps correspond to the execution phase's instead of the validation's.

Note: I'm using the Go SDK, but I suspect this isn't SDK-specific.

Desired behavior

I'd expect the "Starting validation" message to have the total steps of the validation phase instead of the execution phase's.

What is the severity of this bug?

Papercut; this bug is frustrating, but I have a workaround.

What area of the product does this pertain to?

SDK: the Software Development Kit libraries - Typescript, Go, etc.

tedim52 commented 1 week ago

Hey @MegaRedHand thanks for making the issue! Will take a look to see why this. Also curious, could you elaborate more on how this is causing friction in your workflow? (eg. are you expecting using number steps as a termination condition?)

MegaRedHand commented 1 week ago

Hey! Thanks for the response! I'm using the engine responses to show the user a progress bar. Initially, I was using the steps returned in the "Starting validation"/"Starting execution" messages to set the "total steps". Due to this, however, I use the info from the following messages instead.