search

kurtosis-tech / kurtosis

A platform for packaging and launching ephemeral backend stacks with a focus on approachability for the average developer.
https://docs.kurtosistech.com/
Apache License 2.0
352 stars 47 forks source link

`request` and `exec` does not offer timeout mechanism #557

Open victorcolombo opened 1 year ago

victorcolombo commented 1 year ago

Background & motivation

Currently wait has a timeout field to indicate the maximum time a single call of recipe should take, before moving on to the next call: https://docs.kurtosis.com/starlark-reference/plan/#wait

There is no way to define such timeout on the one-off counterparts request and exec, letting us being on the mercy of the HTTP client timeout, that is not documented in Kurtosis Docs.

Desired behaviour

request and exec should have sane, documented timeout defaults and make it customizable. Ideally timeout could be part of recipe instead of being binded by the recipe executor

How important is this to you?

Nice to have; this feature would make using Kurtosis more enjoyable.

mieubrisse commented 1 year ago

FWIW run_sh does have this, and we should move towards using run_sh for these sorts of things