search

kurtosis-tech / kurtosis

A platform for packaging and launching ephemeral backend stacks with a focus on approachability for the average developer.
https://docs.kurtosistech.com/
Apache License 2.0
313 stars 42 forks source link

deprecate custom mocks in favor of mockery mocks #942

Open h4ck3rk3y opened 11 months ago

h4ck3rk3y commented 11 months ago

Background & motivation

We have a couple of mocks that are generated by mockery and also have been written by us. Last week I was breaking my head over a code path and after taking a break I realized that the class I was looking at was wrong. I know of two mocks that are generated by both mockery and human - service network ( appends _custom to file) and package content provider (they share the same name).

Desired behaviour

Ideally we do everything via mockery and remove the custom implementations

How important is this to you?

Painful; the lack of this feature makes using Kurtosis frictionful.

gbouv commented 11 months ago

Removed the one for service network in https://github.com/kurtosis-tech/kurtosis/pull/945. package-content-provide still pending.