We don't set the terminal difficulty in the EL genesis data even though the struct expects it

kurtosis-tech / zzz-deprecated-eth2-merge-kurtosis-module

Deprecated in favor of https://github.com/kurtosis-tech/eth2-package

29 stars 23 forks source link

We don't set the terminal difficulty in the EL genesis data even though the struct expects it #147

Closed h4ck3rk3y closed 1 year ago

h4ck3rk3y commented 1 year ago

https://github.com/kurtosis-tech/eth2-merge-kurtosis-module/blob/c7e67c5646eb18a94b1b9ab11c478c7c58002a60/kurtosis-module/impl/participant_network/prelaunch_data_generator/el_genesis/el_genesis_data_generator.go#L89

gbouv commented 1 year ago

Yup good point, those are irrelevant now that we're not doing the merge anymore. Submitted a PR to clean those up. The ETH folks merged a PR on the data generator, we could use it in a more efficient way right now I believe (I think we could completely remove the templating logic). I looked into it on Friday but adapting the module is not trivial, so I figured it should be properly prioritised before I burn too much time. I'll file another issue to track

gbouv commented 1 year ago

Files kurtosis-tech/eth2-package#56