search

kurtsson / jekyll-multiple-languages-plugin

I18n support for Jekyll and Octopress
MIT License
923 stars 201 forks source link

Build translations in `pre_render` hook #122

Closed satzz closed 5 years ago

satzz commented 6 years ago

Fix against https://github.com/Anthony-Gaudino/jekyll-multiple-languages-plugin/issues/121

In order to enable site.translations(not t), I made a fix to build site in pre_render(not post_render). https://github.com/jekyll/jekyll/blob/master/lib/jekyll/site.rb#L187

joshcummingsdesign commented 6 years ago

Have the same issue and confirmed this works. Any way this can be merged?

satzz commented 5 years ago

So how's the review progress? @Anthony-Gaudino @kurtsson

kurtsson commented 5 years ago

So how's the review progress? @Anthony-Gaudino @kurtsson

Hi @satzz, @Anthony-Gaudino took over the maintenance of this project a few years ago but he seems to have disappeared unfortunately. Do you have time to take ownership?

kleuter commented 5 years ago

I'd be happy if anyone could take ownership of this great project, there're so many important PR already.

satzz commented 5 years ago

Oh not sure but interested. What do I need to take ownership?

kurtsson commented 5 years ago

@satzz basically verify the prs and their continued functionality. I can push a new version after that if you want.

kurtsson commented 5 years ago

In short this project really need a new owner, is that you? Or can you atleast verify all PRs so I can merge and make a release?

joshcummingsdesign commented 5 years ago

@kurtsson This can be merged.