search

kurtsson / jekyll-multiple-languages-plugin

I18n support for Jekyll and Octopress
MIT License
923 stars 201 forks source link

Fix for issue #77: Load the translation each time #141

Closed kevinleguillou closed 5 years ago

kevinleguillou commented 5 years ago

When reviewing the Site:Pre_render hook, I've noticed the plugin would only load the YAML translation files once then ignoring it. Translation aren't taken into account unless you build again, making the plugin difficult to use with jekyll serve.

Unless there is a performance issue (I don't see one using my current fork), I suggest we remove the unless condition and load the YAML file each time on the Site:Pre_render hook.

shushugah commented 5 years ago

Thank you @kevinleguillou, this makes a lot of sense! I will merge this PR. If there are performance considerations, then those should be added with some kind of flag, for example jekyll serve --cache-t but for now, this is simpler way to go!