search

kurtsson / jekyll-multiple-languages-plugin

I18n support for Jekyll and Octopress
MIT License
923 stars 201 forks source link

🎉 Fix Travis Builds. Upgrade bundler dependency and loosen jekyll requirements #151

Closed shushugah closed 4 years ago

shushugah commented 4 years ago

Absent testing coverage (on our ToDo list) we have an example website, which is tested with HTML proofer for any broken links, using explicit and fallback translations. This build now passes @kurtsson

Next steps are

  1. Add tests
  2. Run this build for multiple (or oldest at least) versions of ruby, and multiple versions of jekyll, in order to detect regressions, especially since Jekyll 4.0 is new, and does not have i18n yet
rudygodoy commented 4 years ago

Tested the branch with a Jekyll 4.0 website and it works fine.

thomaspeitz commented 4 years ago

@kurtsson / @shushugah - Same for our company - Gem works fine on jekyll 4. Any chance we get a new release of the gem with a merge of this? <3

kleuter commented 4 years ago

Please, please release the plugin for 4.0, thanks.

shushugah commented 4 years ago

@kurtsson

kurtsson commented 4 years ago

Sure! No problem, what would be a good version number for this release?

shushugah commented 4 years ago

Yep! None of the PR's have breaking changes, now translations are automatically rebuilt every time page is loaded during development and links to collections are translated. Rest are test improvements

kurtsson commented 4 years ago

@kurtsson / @shushugah - Same for our company - Gem works fine on jekyll 4. Any chance we get a new release of the gem with a merge of this? <3

v1.6.1 is released with the fixes. Thank you everyone!