search

kurtsson / jekyll-multiple-languages-plugin

I18n support for Jekyll and Octopress
MIT License
922 stars 203 forks source link

absolute_url broken with Jekyll 4.1.0 #168

Open megastep opened 4 years ago

megastep commented 4 years ago

I am working on a website that's translated using the jekyll-multiple-languages-plugin. I just tried to upgrade from Jekyll 4.0 to Jekyll 4.1.0 (the current version right now) and suddenly it appears that the absolute_url filter is broken.

The behavior in previous versions of Jekyll would be that it would prepend the locale subdirs as necessary; however as of Jekyll 4.1 it is now always returning the root of the site regardless of the language being processed. This breaks many links on my site, of course.

I am not sure if this is a temporary issue in Jekyll itself or something that should be addressed in this plugin, but I think you should be aware of this in case you can address it.

torrocus commented 4 years ago

It's probably related with this pull request: https://github.com/jekyll/jekyll/pull/7793

torrocus commented 4 years ago

Unfortunately, this problem needs to be solved on the side of this plugin. The problem concerns not only absolute_url, but also relative_url.

kleuter commented 4 years ago

True, relative_url filter is broken for me too.

shushugah commented 3 years ago

I am unable to reproduce it, can you provide an example?