search

kurttheviking / git-rev-sync-js

Synchronously get the current git commit hash, tag, or branch
MIT License
169 stars 57 forks source link

Improve submodule checking #23

Closed henrikra closed 7 years ago

henrikra commented 7 years ago

Problem was when using git-rev-sync inside virtual machine. Then parentRepoPath would be host machine's path. This is wrong because path is sometimes absolute. Now it checks upper folder which is parent repo and it's module folder if it has this child repo as submodule

henrikra commented 7 years ago

@kurttheviking Busy with the kid? :D

kurttheviking commented 7 years ago

@henrikra I have shipped an updated version (git-rev-sync@1.9.0). Feel free to upgrade and let me know if you encounter any issues. Thanks!

Arkkimaagi commented 7 years ago

I'm from the same team as @henrikra, we just upgraded the git-rev-sync to 1.9.0 and it seems to be working nicely. Thanks!

kurttheviking commented 7 years ago

@Arkkimaagi great thanks!