search

kurttheviking / uuid-with-v6-js

UUID Version 6 for Node.js
ISC License
17 stars 6 forks source link

Typescript #2

Open kael-shipman opened 3 years ago

kael-shipman commented 3 years ago

This PR dresses the library with Typescript. It also removes some tests that seem less than ideal. In particular, there are several tests that verify internal implementation (such as "proxies v1 function of uuid", etc). These tests were deemed unnecessary (and inconvenient) in light of the fact that the library interface itself is fully covered by tests.

kael-shipman commented 3 years ago

@kurttheviking please let me know if you're interested in this and/or if there's anything that you'd like me to do to make this PR more appetizing to you :).

Papooch commented 3 years ago

Bumping. I would also like to see this merged.

kael-shipman commented 3 years ago

Note that you can also just use my fork by requiring @kael-shipman/uuid-with-v6 at version ^2.0.0. To do this, however, you must set your repo up for GitHub packages and point npm to my GitHub namespace. If you need help, i can explain more when I'm back to my computer.

Papooch commented 3 years ago

Yes, I figured, thank you, but I'd rather use the npm distribution given that I'm using it in many projects. I'll wait a couple of days if @kurttheviking notices this.

kurttheviking commented 3 years ago

Sure; let me take a look -- I haven't yet because the Travis build was complaining and it's usually easier to clean that up prior to the merge. I don't want to remove the tests though -- most of those were added in response to other bugs we found during use in live settings.

ghost commented 2 years ago

While reviewing dependencies, I noticed that npm now throws warnings that this version is depending on a very old version of uuid. If merging this PR requires too much work, would it be possible to at least loosen the dependencies? Let's not let UUIDv6 die!