Support document inclusion

kurusugawa-computer / markdown-copilot-vscode

OpenAI ChatGPT API client for VSCode

https://marketplace.visualstudio.com/items?itemName=kurusugawa-computer.markdown-copilot

MIT License

9 stars 2 forks source link

Support document inclusion #10

Closed maekawatoshiki closed 3 months ago

maekawatoshiki commented 4 months ago

Summary

Issue: #3
Adds support for syntax @import "markdown.md", which inserts file content into the active context.
- This syntax is supported by Markdown Preview Enhanced.

squld commented 4 months ago

Could you clarify whether the implementation accounts for recursive and cyclic imports? Users might anticipate behavior consistent with that of Markdown Preview Enhanced.

maekawatoshiki commented 4 months ago

I noticed that Markdown Preview Enhanced on my environment enters infinite loop when there's cyclic imports. It is not clearly stated what is supposed to happen.

squld commented 4 months ago

Markdown Preview Enhanced on my environment enters infinite loop when there's cyclic imports.

Thank you for the interesting report on the results 🤣 For now, we don't need to care about handling cyclic imports. If it's easy, I would like you to implement recursive imports.

squld commented 3 months ago

Now that this feature is complete, we merge the pull request.