kurusugawa-computer / markdown-copilot-vscode

OpenAI ChatGPT API client for VSCode
https://marketplace.visualstudio.com/items?itemName=kurusugawa-computer.markdown-copilot
MIT License
9 stars 2 forks source link

Indicate completion #17

Closed maekawatoshiki closed 3 months ago

maekawatoshiki commented 3 months ago

Summary

squld commented 3 months ago

Is it possible to display the Markdown Copilot icon at the height of one line instead of πŸ“?

maekawatoshiki commented 3 months ago

It seems like we can implement it, but we need a small icon that fit in line. (https://github.com/Microsoft/vscode/issues/47086 and my experience suggest 'width' and 'height' for the icon can not be applied.)

maekawatoshiki commented 3 months ago

16x16 icon at the end of the line:

IMO I can barely notice that it is an indicator icon of the extension due to its size.

Emoji looks better, since its resolution can change depending on font size.

γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2024-05-24 22 25 37

squld commented 3 months ago

Emoji looks better, since its resolution can change depending on font size.

Thank you for your survey. Let us adopt the emoji!

squld commented 3 months ago

Please also display an indicator when titling with the COMMAND_MARKDOWN_COPILOT_EDITING_TITLE_ACTIVE_CONTEXT command. It might be a good idea to give the Completion class the responsibility of displaying indicators.

maekawatoshiki commented 3 months ago

Now Completion indicates at the end of completion text with πŸ“.

When naming the title, the emoji is shown at the start of the next line Copilot actually completes. This is because the anchor offset points there. Should we fix that?

squld commented 3 months ago

When naming the title, the emoji is shown at the start of the next line Copilot actually completes. This is because the anchor offset points there. Should we fix that?

Please fix if you can easily.

maekawatoshiki commented 3 months ago

I've tried some promising fixes (e.g. decreasing the anchor offset if it points at line separator), but they are just workarounds in the end.

Do you have any ideas? I don't have an appropriate idea for now.

squld commented 3 months ago

Do you have any ideas? I don't have an appropriate idea for now.

There is no need to resolve the issue immediately.

Let's prioritize the release of this pull request. Please add the changes to CHANGELOG.md.

maekawatoshiki commented 3 months ago

Updated CHANGELOG. Release date is not specified.