kurzgesagt-in-a-nutshell / birdbot

A multipurpose bot for the kurzgesagt discord server
GNU General Public License v3.0
20 stars 4 forks source link

Fix/pyright #201

Closed sloth-ontabasco closed 5 months ago

sloth-ontabasco commented 5 months ago

Fix Pyright Config

Description

Includes instructions to add local virtualenv folder under the exclude rule for the pyright tool

Purpose

Prior to this change pyright will end up running on all files including the venv causing errors

Checklist

arcinfini commented 5 months ago

What is the benefit for listing the project dependencies in the pyproject.toml file when requirements.txt exists?

I don't see a reason to keep it manually updated when we do not have poetry to use with it. All I see is us forgetting to maintain one over the other and creating confusion.

Other than that, I have tested the pyright check and this change does resolve it 👍

sloth-ontabasco commented 5 months ago

What is the benefit for listing the project dependencies in the pyproject.toml file when requirements.txt exists?

I don't see a reason to keep it manually updated when we do not have poetry to use with it. All I see is us forgetting to maintain one over the other and creating confusion.

Other than that, I have tested the pyright check and this change does resolve it 👍

I am aligned on using poetry moving forward if the team is fine with it. (refer discord chat) and maintaining a single dependency list. This change is an exception before we standardize our package management tool and as such serves no additional benefit