Closed sloth-ontabasco closed 5 months ago
What is the benefit for listing the project dependencies in the pyproject.toml file when requirements.txt exists?
I don't see a reason to keep it manually updated when we do not have poetry to use with it. All I see is us forgetting to maintain one over the other and creating confusion.
Other than that, I have tested the pyright check and this change does resolve it 👍
What is the benefit for listing the project dependencies in the pyproject.toml file when requirements.txt exists?
I don't see a reason to keep it manually updated when we do not have poetry to use with it. All I see is us forgetting to maintain one over the other and creating confusion.
Other than that, I have tested the pyright check and this change does resolve it 👍
I am aligned on using poetry moving forward if the team is fine with it. (refer discord chat) and maintaining a single dependency list. This change is an exception before we standardize our package management tool and as such serves no additional benefit
Fix Pyright Config
Description
Includes instructions to add local virtualenv folder under the
exclude
rule for the pyright toolPurpose
Prior to this change pyright will end up running on all files including the venv causing errors
Checklist