Closed euri10 closed 2 years ago
well @kushaldas I rebased this one as well, signed the commits, and the CI still doesn not kick in I'm afraid, not sure what I could do on my side, but let me know if I may help, would gladly do it !
Can you try to login to circleci and see if you can enable CI for the PR?
ok CI work, and I rebased, but I need to update the PR as new testss apparently were introduced and I still have some jce.db in /tmp
working on it,
@kushaldas ! this is ready, thanks for the tip on logging in Cirlce CI
I find strange and not obvious I need to be logged in my fork and run the CI there, TIL something at least :) I wish I knew that sooner
I find strange and not obvious I need to be logged in my fork and run the CI there, TIL something at least :) I wish I knew that sooner
Even I never knew, I just asked to see if that solves it or not :)
I will review this tomorrow.
This build on previous PR and uses the built-in pytest fixture
tmp_path
instead of the xunit_style setup_moduleThis way your /tmp folder is not cluttered anymore with all the files created, and you're not forced into your tests to think about deleting created files.