search

kushaldas / johnnycanencrypt

Python module for OpenPGP written in Rust.
GNU Lesser General Public License v3.0
51 stars 9 forks source link

Use pytest fixtures for temporary files and directories #110

Closed euri10 closed 2 years ago

euri10 commented 2 years ago

This build on previous PR and uses the built-in pytest fixture tmp_path instead of the xunit_style setup_module

This way your /tmp folder is not cluttered anymore with all the files created, and you're not forced into your tests to think about deleting created files.

euri10 commented 2 years ago

well @kushaldas I rebased this one as well, signed the commits, and the CI still doesn not kick in I'm afraid, not sure what I could do on my side, but let me know if I may help, would gladly do it !

kushaldas commented 2 years ago

Can you try to login to circleci and see if you can enable CI for the PR?

euri10 commented 2 years ago

ok CI work, and I rebased, but I need to update the PR as new testss apparently were introduced and I still have some jce.db in /tmp

working on it,

euri10 commented 2 years ago

@kushaldas ! this is ready, thanks for the tip on logging in Cirlce CI

I find strange and not obvious I need to be logged in my fork and run the CI there, TIL something at least :) I wish I knew that sooner

kushaldas commented 2 years ago

I find strange and not obvious I need to be logged in my fork and run the CI there, TIL something at least :) I wish I knew that sooner

Even I never knew, I just asked to see if that solves it or not :)

I will review this tomorrow.