search

kushaldas / johnnycanencrypt

Python module for OpenPGP written in Rust.
GNU Lesser General Public License v3.0
51 stars 9 forks source link

Consider adding Cargo.lock to repo #125

Closed dotlambda closed 1 year ago

dotlambda commented 1 year ago

Since johnnycanencrypt is not supposed to be used by other Rust projects, its Cargo.lock should be committed and removed from .gitignore: https://github.com/rust-lang/cargo/issues/315 This would help with packaging the Python module in a reproducible way.

kushaldas commented 1 year ago

Thank you @dotlambda for opening the issue. Will fix this.

dvzrv commented 1 year ago

This would be really great to have for packaging this project on downstream distributions! :)

kushaldas commented 1 year ago

This is done.

dotlambda commented 1 year ago

This is done.

It's not: https://github.com/kushaldas/johnnycanencrypt/blob/main/Cargo.lock. You need to actually commit the file.