search

kushaldas / johnnycanencrypt

Python module for OpenPGP written in Rust.
GNU Lesser General Public License v3.0
51 stars 9 forks source link

Update KeyStore to use Path than string #148

Closed kushaldas closed 11 months ago

kushaldas commented 11 months ago

Right now we are using strings to store the KeyStore database path. We should instead use pathlib.Path everywhere. This will also help for the tests on Windows.

euri10 commented 11 months ago

I came to the same conclusion looking at your PR @kushaldas , which I expanded on ( see below), solved almost all issues but a rather big and annoying one on th db upgrade, it fails on renaming the file with a PermissionError I ended up giving up because I dont have windows and debugging in the CI was rather not fun

https://github.com/euri10/johnnycanencrypt/tree/tests_on_windows

kushaldas commented 11 months ago

I ended up giving up because I dont have windows and debugging in the CI was rather not fun

I can understand the pain :) I am focusing on all the other things to clean up first. And then I will look into Windows update. One step at a time. I may do a few more PRs before I go back to windows land. We will know soon :D