search

kushaldas / johnnycanencrypt

Python module for OpenPGP written in Rust.
GNU Lesser General Public License v3.0
51 stars 9 forks source link

delete_key method should clean all the cache dictionaries #20

Closed kushaldas closed 4 years ago

kushaldas commented 4 years ago

Right now we only delete from the fingerprints_cache but we also have values_cache and emails_cache and names_cache.

kushaldas commented 4 years ago

I am thinking what if we should just hold the fingerprints in the all the other caches, and get retrieve the key from the fingerprint_cache as required. Will make it a bit simpler I think. I am also adding a patch to store the UIDs in the Key objects. So, we can easily identify which all places need to be updated for deletion.

@redshiftzero what do you think?

kushaldas commented 4 years ago

We don't need it any more as now we have a SQLite based KeyStore via https://github.com/kushaldas/johnnycanencrypt/pull/27