Modified hardcoded tests paths so that tests can be run whatever cwd is

kushaldas / johnnycanencrypt

Python module for OpenPGP written in Rust.

GNU Lesser General Public License v3.0

51 stars 9 forks source link

Modified hardcoded tests paths so that tests can be run whatever cwd is #87

Closed euri10 closed 2 years ago

euri10 commented 2 years ago

I couldnt run straight in pycharm the tests, because it sets the cwd to the tests directory by default and realized all paths are hardcoded, this PR just sets the path irrelative to the cwd, As i'm using Path I had sometimes to use the .as_posix() method to get strings

kushaldas commented 2 years ago

@euri10 Thank you for the set of PRs. I am wondering why did not the tests run/finished. I will have a look and first try to merge these before any new feature.

euri10 commented 2 years ago

@euri10 Thank you for the set of PRs. I am wondering why did not the tests run/finished. I will have a look and first try to merge these before any new feature.

I've limited to say 0 experience with circle ci so I wont be of good advice on this one !

euri10 commented 2 years ago

closing this as I think the change of branch from master to main lead github PR to not take changes in my branch ( attempt at merging main in this) into account