kushalj001 / pytorch-question-answering

Important paper implementations for Question Answering using PyTorch
MIT License
274 stars 50 forks source link

Character Embedding Layer #9

Closed Marwa199527 closed 2 years ago

Marwa199527 commented 3 years ago

Hi, I am not familiar with CNN so I hope you clarify something for me, in the character embedding in BiDAF you used Conv2d and the other implementation used it too. if we have a word as an input shouldn't we use Conv1d. I hope you explain why you used Conv2d and if we can use Conv1d. thank you for your work,