search

kushinauwu / OBF-Homepage-New

Raw version of the new homepage
2 stars 13 forks source link

News section - styling comments #16

Closed yochannah closed 5 years ago

yochannah commented 5 years ago

I love seeing the new news section!! <3 The pictures in the background of the post excerpts is a nice touch.

A few comments:

  1. Increase contrast - it's a little hard to read the text, especially on busy background like this image (I feel so old making "It's a little hard to read" comments but oh well 😆 )
  2. Sometimes the excerpt runs off the page a little: image - this also happens to the top one at particularly narrow screen widths - I wonder if CSS grid might help with this?
  3. Some of the background images are a bit skewed - is it possible to preserve aspect ratio?

Other than that, it looks good! I tested squishing and expanding the browser window and it seems clear you've put thought into making the media queries work nicely! 👍

kushinauwu commented 5 years ago

image The aspect ratio is the same as the original picture now! :) I increased the brightness too, haha don't worry, I found it hard to read myself when I looked it over!

yochannah commented 5 years ago

we're re-styling htis in another issue