kushview / element

Element Audio Plugin Host
https://kushview.net/element/
1.18k stars 99 forks source link

Element crashes the DAW when opening saved session if 'OVERSAMPLE' setting other then 'x1' used on any 3-d party plugin. #202

Closed Oortseam closed 4 years ago

Oortseam commented 4 years ago

Describe the bug

Element VST crashes the DAW (Reaper v.6.0) when opening previously saved session if 'OVERSAMPLE' setting other then 'x1' used on any 3-d party VST plugin.

To Reproduce

Steps to reproduce the behavior:

  1. Open new Reaper session.
  2. Insert Element on empty track.
  3. Insert any VST(i) plugin inside Element.
  4. Set OVERSAMPLING to something other then 'x1'
  5. Save session.
  6. Close it.
  7. Open it.
  8. Result: the DAW crashes.

Expected behavior

The DAW doesn't crash :)

Desktop (please complete the following information):

OS: windows 10x64 v.1903.18362.30 DAW: Cockos Reaper v. 6.0 Element version: 1.43.2

Standalone or Plugin Plugin

Additional context

Additional notes:

  1. It crashes ONLY if sound driver is active. When you start DAW with audio closed, the session loads without a crash. It crashes only in the time you activate audio.
  2. If you change previously saved with the session oversampling settings in "no audio" DAW mode and then make audio on, then it doesn't!
  3. It crashes ONLY if 3-d party plugin has input audio ports (no matter either they connected/muted or not)
mfisher31 commented 4 years ago

I couldn't reproduce this @Oortseam . By chance was it crashing on a mono track. If so I think the fix is here: e550fca94fca29393328b7f12f75cc835c8f4448

mfisher31 commented 4 years ago

Should be fixed in e550fca and in master branch.