kushview / element

Element Audio Plugin Host
https://kushview.net/element/
1.08k stars 95 forks source link

macOS: Bunde Identifier not set #773

Closed ni-swastl closed 3 weeks ago

ni-swastl commented 2 months ago

Describe the bug The released macOS bundle does not have a bundle identifier set in its plist

To Reproduce Steps to reproduce the behavior:

  1. Show package content of macOS bundle
  2. Switch to "Raw key and values"
  3. Look for CFBundleIdentifier
  4. (not found)

Expected behavior macOS application bundle requires a bundle identifier

Screenshots N/A

Desktop (please complete the following information):

Standalone or Plugin Standalone, 0.46.6

Additional context The "Jucer" file apparently has the property set: bundleIdentifier="net.kushview.Element", but it is obviously not used when building the application distributed on the web site.

mfisher31 commented 1 month ago

Probably won't fix this for 0.46, but I added to 1.0.

ni-swastl commented 1 month ago

Workaround:

/usr/libexec/PlistBuddy -c "Add :CFBundleIdentifier string net.kushview.Element" ./Element.app/Contents/Info.plist

mfisher31 commented 3 weeks ago

checkint the meson.build's. This is already done in develop