Flow _lifetime metrics are actually gauges

VCCPlindsten commented 1 week ago

Description of the Issue

The flow metrics exposed by logstash API are in fact gauges, that is, average over the timeframe described (current being 10s). Upstream doc: https://www.elastic.co/guide/en/logstash/current/node-stats-api.html#flow-stats

This may have been different in previous logstash versions?

logstash-exporter lists the following _lifetime metrics as counters, but the values behave like gauges (In logstash 8.15)

logstash_stats_flow_filter_lifetime
logstash_stats_flow_input_lifetime
logstash_stats_flow_output_lifetime
logstash_stats_flow_queue_backpressure_lifetime
logstash_stats_flow_worker_concurrency_lifetime
logstash_stats_pipeline_flow_filter_lifetime
logstash_stats_pipeline_flow_input_lifetime
logstash_stats_pipeline_flow_output_lifetime
logstash_stats_pipeline_flow_queue_backpressure_lifetime
logstash_stats_pipeline_flow_worker_concurrency_lifetime

In addition to changing the type, the help text should probably also be changed to indicate that this is the rate over the lifetime, rather than a total

Version of logstash-exporter, or logstash-exporter Image

1.7.1

Version of Chart (if applicable)

No response

Operating System/Environment

Logstash 8.15.0

Logs

No response

kuskoman commented 1 week ago

Fixed for v1 @satk0 could you make a fix for v2?

satk0 commented 1 week ago

yup

satk0 commented 1 week ago

@kuskoman Done

VCCPlindsten commented 4 days ago

Suggestion for updating node-level metric types: #374 Pipelines was addressed by @satk0

satk0 commented 2 days ago

Yea, if you find any other issue with exporter, don't hesitate on reporting it, you are really helpful !

kuskoman / logstash-exporter