search

kusnier / vagrant-persistent-storage

A Vagrant plugin that creates a persistent storage and attaches it to guest machine.
MIT License
292 stars 68 forks source link

Make Partitioning Optional and Fix Configuration Validation #70

Closed BenPhegan closed 7 years ago

BenPhegan commented 7 years ago

Hi,

Firstly, thanks for the work on this! This PR is aimed at providing the ability to specify whether we use partitioning or not. It is very similar to https://github.com/kusnier/vagrant-persistent-storage/pull/65

Differences:

  1. I had some problems with the implementation on 65 regarding turning off partitioning reducing the set of operations carried out to the extent that the plugin did not function as required.
  2. Issues with the resultant disk devices being indexed incorrectly.

Also had a go at validating the configuration, as it appeared that this was not being done before, resulting in some confusion as to what settings were and were not being applied.

Also added some additional information and clarification to the readme.

Look forward to your feedback!

Thanks,

Ben

BenPhegan commented 7 years ago

@sourceindex @TonyApuzzo Would be interested in your feedback on this as well.

TonyApuzzo commented 7 years ago

I am too ignorant to compile and install the plugin from the the PR, what I did before was install the base plugin and then manually update the corresponding files directly in the installed gems folders. I will do this with the latest commit and try my test case (creating a dedicated LVM for use with the Docker LVM storage mapper.)

kusnier commented 7 years ago

Released with 0.0.27

BenPhegan commented 7 years ago

Thanks, appreciated!

kusnier commented 7 years ago

I have reverted this pr because this has broken the plugin. can you check your changes and make a new pull request?

BenPhegan commented 7 years ago

Apologies if it has. Do you have any details on how it has broken the plugin? Happy to fix, but it works for our usecases, not sure what to test.

kusnier commented 7 years ago

i have tested it with the sample in this repo.

cd sample-vm vagrant up vagrant ssh

mount | grep mysql

/dev/mapper/myvolgroup-mysql on /var/lib/mysql type ext4 (rw)

With your changes the mount was not available. I wanted to fix it by myself but i have not so much time and giving up after some time. thanks

BenPhegan commented 7 years ago

Alrighty, have fixes plus an automated test suite. Will put through a pull request on another branch tomorrow morning. Sorry about the issues.

kusnier commented 7 years ago

I'm very excited. Thank you