search

kusnier / vagrant-persistent-storage

A Vagrant plugin that creates a persistent storage and attaches it to guest machine.
MIT License
292 stars 68 forks source link

Fix issues with partition option and defaulting of config. Added an easier automated test approach #75

Closed BenPhegan closed 7 years ago

BenPhegan commented 7 years ago

So this pull request should now:

  1. Add partition option
  2. Fix validation of configuration options
  3. Fix defaulting of configuration based on incorrect checking of empty (change of types messed this up)
  4. Add a simple test.sh file that automates spinning up a few different Vagrant test files. This still requires the gem to be built and installed (consider this a TODO that I did not have strong enough background in Ruby to fully automate). This will spin up and tear down boxes and test them, simple single test set up at the moment but should be easy to extend.

It was a bit messy due to revert and other pulls coming in, but I think it is now in pretty good shape.

Let me know if any of it does not work/is unclear.

Regards,

Ben

kusnier commented 7 years ago

Very beautiful. Thanks for the automated test. This will help my to test any other changes.