search

kusnier / vagrant-persistent-storage

A Vagrant plugin that creates a persistent storage and attaches it to guest machine.
MIT License
292 stars 68 forks source link

use_lvm=true should default mount & format false #79

Closed robnagler closed 6 years ago

robnagler commented 7 years ago

If you are using the LVM, you don't want to modify fstab or format the volume.

I'm using this for a docker thinpool, which means I need to wipe signatures. Even though I supply "y" to lvcreate, it still fails with a prompt:

lvcreate --wipesignatures y -n thinpool docker -l 95%VG
WARNING: ext3 signature detected on /dev/docker/thinpool at offset 1080. Wipe it? [y/n]:

Also, the logical volume created is changed so /etc/fstab is incorrect after that change. LVM already manages the mount table so I don't think you ever want vagrant-persistent-storage to modify it with use_lvm=true.

Ideally, if you were to specify a volgroupname, use_lvm should default to true, too, but that's less problematic.

robnagler commented 6 years ago

New docker version doesn't use thinpools