search

kusold / todoist-habitrpg

One way sync from Todoist -> HabitRPG
120 stars 14 forks source link

Repeating events #14

Closed crookedneighbor closed 9 years ago

crookedneighbor commented 9 years ago

Fix for #13

Note, this doesn't take into account more complicated "every" date_strings like: "every 5 days starting next monday" or "every 2nd monday". Both those cases would see the word monday and make it so the daily is active every Monday, which may not be what is desired since that'll result in hp loss on Monday if it's not checked.

Thought this would be a good way to get this started though.

crookedneighbor commented 9 years ago

Just added some code that checks if "after" or "starting" is in the date string. If so, it makes all the days of the weak false. I figure, better safe than sorry. Don't want to lose HP for a daily that wasn't supposed to be active.

Added an additional adjustment to Thursday so it wouldn't get activated with writing something like every 4th mon. (the th in 4th)

crookedneighbor commented 9 years ago

Updated it so it'll recognize every day and every weekday.

crookedneighbor commented 9 years ago

I think the only thing left to do now is handle non-repeating events that get changed to repeating events and vice-versa.

kusold commented 9 years ago

I'm going to look at this tonight. Sorry it has taken so long. Also, before this gets merged in I'd like to get the CI green. If it passes locally but fails on CI then I'll try to tweak the CI script.

kusold commented 9 years ago

Thanks for this. I added tests around this last night and fixed some issues those tests exposed. This is published in v0.3.0

crookedneighbor commented 9 years ago

That's awesome, thanks!

Not sure if you've been following this, but repeating events are going to change a little soon.

kusold commented 9 years ago

Thanks. I must have missed that issue last time it was referenced. I'm now following it closely.