search

kustodian / extended-statusbar

Firefox addon which adds a statusbar with speed, percentage, time and loaded size (similar to Opera's one)
https://addons.mozilla.org/en-US/firefox/addon/extended-statusbar/
GNU General Public License v3.0
18 stars 6 forks source link

Fix #21 ESB disappears when moved to Menu Bar after restart #22

Closed sipertruk closed 10 years ago

sipertruk commented 10 years ago

More Customizableui, the fun never ends.

adoxa commented 10 years ago

Beat me to it again, and did it better, again. :smile:

kustodian commented 10 years ago

I'll test it out and if it works I think that we have everything we need for the next release, 2.0 :smiley:

kustodian commented 10 years ago

Now after restarting it saves everything correctly, but there is a problem with reinstalling ESB. If I reinstall the same version, it says that ESB was successfully installed and since it is a restartless extension it should work out of the box, but it doesn't. After ESB has been installed again, it stops working until I restart FF. This means we will have problems when we update ESB. Could you check out what is the problem?

sipertruk commented 10 years ago

I tried re-installing the latest version from this fix over and over and it doesn't ask to restart.

Do you mean installing the restart less version over the non restart less ? If yes it's normal, it takes a restart to uninstall a non restart less addon. If no, maybe there's a special way to reproduce the bug or some useful info in the console ?

kustodian commented 10 years ago

No, I'm talking about this version. I don't have an old (restartless) version installed for a long time now.

Basically I installed this pull request over the previous master version and ESB installed, but all the fields were blank. Than I restarted FF and it worked. Then I tried installing this same version again (over itself basically), it said that it installed successfully, but yet again all the fields became blank again, until I restarted FF.

kustodian commented 10 years ago

Here is the output it generated on the browser console when I reinstalled ESB:

No chrome package registered for chrome://dta-modules/content/support/filtermanager.js
Duplicate resource declaration for 'specialpowers' ignored. chrome.manifest:32
Duplicate resource declaration for 'gre-resources' ignored. chrome.manifest:34
Duplicate resource declaration for 'services-sync' ignored. components.manifest:168
Duplicate resource declaration for 'services-common' ignored. components.manifest:170
Duplicate resource declaration for 'services-crypto' ignored. components.manifest:171
Could not read chrome manifest 'file:///C:/Program%20Files%20(x86)/Mozilla%20Firefox/chrome.manifest'.
Duplicate resource declaration for 'pdf.js' ignored. pdfjs.manifest:1
Ignoring obsolete chrome registration modifier 'xpcnativewrappers=no'. chrome.manifest:16
Duplicate resource declaration for 'scriptish' ignored. chrome.manifest:13
Duplicate resource declaration for 'imagezoom' ignored. chrome.manifest:36
"ExtendedStatusbar stopped" extendedstatusbar.js:79
Duplicate resource declaration for 'testpilot' ignored. chrome.manifest:1
Duplicate resource declaration for 'tabmixplus' ignored. chrome.manifest:3
Could not read chrome manifest 'file:///C:/Program%20Files%20(x86)/Mozilla%20Firefox/browser/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D/chrome.manifest'.
No chrome package registered for chrome://extendedstatusbar/locale/extendedstatusbar.properties
1405175267756   Services.Metrics.Provider.org.mozilla.addons    WARN    Add-on type without field: userstyle
1405175267756   Services.Metrics.Provider.org.mozilla.addons    WARN    Add-on type without field: userscript
1405175267817   addons.xpi  WARN    Exception running bootstrap method startup on {daf44bf7-a45e-4450-979c-91cf07434c3d}: [Exception... "Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIStringBundle.GetStringFromName]"  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame :: chrome://extendedstatusbar/content/extendedstatusbar.js :: XULExtendedStatusbarChrome.esbXUL.init :: line 353"  data: no] Stack trace: XULExtendedStatusbarChrome.esbXUL.init()@extendedstatusbar.js:353 < XULExtendedStatusbarChrome.init()@extendedstatusbar.js:56 < loadIntoWindow()@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kule/AppData/Roaming/Mozilla/Firefox/Profiles/k1a5sbdx.default/extensions/%7Bdaf44bf7-a45e-4450-979c-91cf07434c3d%7D.xpi!/bootstrap.js:255 < forEachOpenWindow()@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kule/AppData/Roaming/Mozilla/Firefox/Profiles/k1a5sbdx.default/extensions/%7Bdaf44bf7-a45e-4450-979c-91cf07434c3d%7D.xpi!/bootstrap.js:290 < startup()@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/kule/AppData/Roaming/Mozilla/Firefox/Profiles/k1a5sbdx.default/extensions/%7Bdaf44bf7-a45e-4450-979c-91cf07434c3d%7D.xpi!/bootstrap.js:24 < XPI_callBootstrapMethod()@resource://gre/modules/addons/XPIProvider.jsm:4232 < AI_startInstall/<()@resource://gre/modules/addons/XPIProvider.jsm:5610 < TaskImpl_run()@resource://gre/modules/Task.jsm:298 < Handler.prototype.process()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:863 < this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:742 < <file:unknown>
sipertruk commented 10 years ago

It looks like the problem described here. Did this fix it?

kustodian commented 10 years ago

Partially. Now ESB works, but the problem is that the ESB toolbar becomes hidden on install, so if ESB is on it, you cannot see ESB until you unhide the ESB toolbar in Customize.

sipertruk commented 10 years ago

I need more info again because I can't reproduce the problem.

kustodian commented 10 years ago

You fixed it now :)