search

kustodian / extended-statusbar

Firefox addon which adds a statusbar with speed, percentage, time and loaded size (similar to Opera's one)
https://addons.mozilla.org/en-US/firefox/addon/extended-statusbar/
GNU General Public License v3.0
18 stars 6 forks source link

First shot for #9 customizable order #27

Closed sipertruk closed 5 years ago

sipertruk commented 10 years ago

I couldn't resist making a cool drag and drop. Follow #9

adoxa commented 10 years ago

I had to add default positions to esbpref.js, but otherwise it worked fine, once I realized I had to right-click and unlock it. Perhaps it might be better to default to unlock so it's immediately obvious things can be moved?

sipertruk commented 10 years ago

Default to unlocked at install, okay if the user is expecting to move boxes, otherwise he 'd be puzzled too. A more general way : option in the setting window Unlock elements positions (same as context menu) perhaps ?

adoxa commented 10 years ago

I did look in settings first, so that would be good.

sipertruk commented 10 years ago

I also changed the setting window open function so that you can't access the main window at the same time. (Just like if you open it in the addons manager). Because it could cause conflict.

adoxa commented 10 years ago

Bring up options, check unlock and OK. Bring up options again, it still shows as unchecked, and everything works opposite.

kustodian commented 10 years ago

This looks very cool and useful :)

I found one minor issue, which might not be an issue. If you leave ESB unlocked and restart FF, it becomes locked when FF is started.

In my opinion you can remove the unlock checkbox in the options menu, since it is enough to have the lock in the context menu. Also the unlock checkbox in the options menu works as a toggle and ignores the OK/Cancel buttons. The other reason why I think it is not needed is because the options menu is a modal window, so you cannot do anything on FF, which also means you cannot drag ESB elements until you close it.

adoxa commented 10 years ago

Yeah, I don't know why I didn't think to right-click in the first place, as that's where this type of option is usually found. Sorry sipertruk!