Add multi-tab support

[kustodian]

Currently ESB only supports the current tab and if you switch between the tabs while the pages are loading, ESB information resets. We need to add multi-tab support so that ESB works even when switching tabs.

[sipertruk]

I added this feature into a new version, just waiting for the incoming update to emerge on mozilla before committing.

Also included:

Merge old-new style, the new style is applied with css rule. A mode where the user can input his own css rules, anything is possible with some basic css knowledge, even skin the toolbar (override of the default skin with -moz-appearance: none;). Slim mode can be applied in any style. Rework the pref window, still in progress. Option to auto-hide the whole toolbar along with the widget if the user has no use of it. Options to hide the progress meter and/or loading cursor.

[kustodian]

Awesome job mate :)

As you can see I added you as a developer into this project, so feel free to commit directly, you don't need to create a pull request.

[sipertruk]

Done. You'll notice the pref window layout is a bit raw and in need of more translation string.

I just noticed "show on over" work no more.Fixed

Added a sort of selector mechanism (extendedstatusbaroptionselector.xul) for option window because the pre australis one is still there. It's a bit ugly but it works.

[kustodian]

I have just installed the newest build and multi-tab support looks awesome! :bow: :bow:

I have a few suggestions:

• Classic style has a colored Loaded item and it wasn't like that before, so those users who use classic style, won't like it. It would probably be better to leave the classic style colorless like before.
• When hiding is enabled and when the tab is switched, ESB always appears and then it hides again. This feels strange and in my opinion it would be better if ESB only appeared if the tab is still loading, if not leave it hidden.
• There is not much of a difference between Classic and New style now. Maybe when you set the classic style to be colorless (at least by default) there would be a bigger difference.
• Options window looks a little out of place as you said and I think we should organize it a little better. Since I'm a sucker for UX, I'll try to think of a better organization for the options dialog.
• I guess the Custom Style in the Options dialog should be replaced by Custom Color, since you can only modify color there.
• For Use your own style, I would probably put something like Use your own style (Advance), since even thought it is an awesome thing to have, it will be a little heavy for most of our users :smile:

After these changes ESB looks almost like a whole new extension. We should even consider to give it version 2.0 :wink:

Really awesome job!

[sipertruk]

Thank you :) Here are my answers to your points in order :

Which points to a bug : the progress bar should have been colored too, fixed. Yes it's different than before but it's just 2 mouse-clicks away with the "hide progress" and "hide cursor" check-boxes.

True, fixed.

Like the first point, all it takes is uncheking the color picker. I have the feeling that the kind of user in need of a progress widget won't feel drown into an ocean of options but well it's only my opinion.

Great.

I am not used to translation handling, should i replace Custom Style with Custom Color in every language file and then the translators kick in ?

I see what you mean :) Fixed. "Use your own style (advanced mode)". I'm thinking about adding hints in tool-tips or such to help with css.

[kustodian]

I still think it would be best that the default look when you install ESB is like before. What I mean is that it would be best to hide percent, progress bar and loading cursor.

Regarding translations, you have to add the string to each translation file. I think you should fill it with English and when I upload it to BabelZilla.org it will detect from the English language that the string is new and send a notification to the translators to update that string.

[sipertruk]

For the translations it's done.

For the progress bar and the loading cursor we could set the default value of hide(..) to true. Remain the percent. Maybe a post upgrade routine would do ? I can't find any doc on such feature. Not that it's hard to code but it exists already in restart less script so I'm thinking I may be searching with the wrong words (and so much data in results..).

[kustodian]

Setting it in defaults as true will be more than enough:

pref("extensions.extendedstatusbar.hideprogress", true);
pref("extensions.extendedstatusbar.hidecursor", true);

[kustodian]

For future reference. I reminded myself how BabelZilla works, and for it to work, you only need to upload the English locale, so next time when you add new strings, just add them into the en-US, do not do anything in other languages.

[kustodian]

In the end I enabled everything to be displayed by default, just as you did it. It makes more sense for the new users. Closing this, since it is done.