kustomzone / plush

Plush is a browser-based shell or terminal.
Apache License 2.0
0 stars 0 forks source link

history is very slow with >300 commands in history #21

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
build up a nice large history (say, over 300 commands)
run plush
type control-R to bring up history...
1) it is slow to display
2) it is slow to filter down
once you select some command, hit return (only once)
3) it is REALLY slow to enter that command and have history comedown

This is mostly due to the fact that the history list is actually styling on the 
scroll back - and involves lots of hiding/showing of divs. Probably the right 
fix is to build a parallel array of strings in JS, and when showing history, 
show just a single overlay-div with a simple list in in of those strings. 
history filtering should be then just removing (or perhaps hiding/showing) 
those list items. My guess is that this will make it much faster.

Original issue reported on code.google.com by mzero@google.com on 11 Dec 2012 at 7:19

GoogleCodeExporter commented 9 years ago
fixed!

Original comment by mzero@google.com on 28 Dec 2012 at 12:41