Closed turbach closed 5 years ago
Merging #157 into refresh will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## refresh #157 +/- ##
========================================
Coverage 87.86% 87.86%
========================================
Files 14 14
Lines 898 898
========================================
Hits 789 789
Misses 109 109
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e8c0ada...3cc51c8. Read the comment docs.
Minimal pin to get
fitgrid
0.4.4.X to passDuring testing the unpinned environment I installed the
i-rkernel
, which downgradedpbdzmq
andzeromzq
andpytest
started passing.I don't know what's causing the problem, but pinning
numpy<=1.16.4
is sufficient to get pytest passing again andnumpy==1.16.5
fails.1.16.5
is a bright line for numpy, the last series to support Python 2.7 and only good for 3.5-3.7https://numpy.org/devdocs/release/1.16.5-notes.html
So for fitgrid,
4.X.Y
just maintenance patches for Python 3.5-3.7 for now.The next series can work to Python 3.8
Here is the sequence ...
Additions and downgrades that allowed fitgrid
pytest
passCould be an addition that filled in a missing dependency or the
zeromq
related downgradesFirst (unlikely) thing to check is a missing dependency
Candidates ... all missing from default fitgrid_compat environment
Test 1
conda install -c r r-base64enc
The following NEW packages will be INSTALLED:
pytest FAILED
Test 2
pytest FAILED
Test 3
pytest FAILED
Test 4
pytest FAILED
Test 5
pytest FAILED
Test 6
pytest FAILED
Interim Conclusion
Problem was not missing
r-*
dependencies. As expected.Problem seems to be pyzmq and/or zeromq
Note: pyzmq and zerozmq are not in the fitgrid env by default
Test 7
pytest FAILED
Notes:
comparison of fitgrid_refresh (pytests pass) with fitgrid_0.4.4.dev0 shows same versions of r-* including downgraded zero mq related python packages.
numpy versions differ
Test 8
downgraded numpy from 1.17.2 to 1.16.4 with previously downgraded zmq friends.
pytests PASS
Test 9
candidate minimal pin for fitgrid 0.4.4
pytest FAILED
Note
So zeromq<4.3 is not sufficient
Test 10
candidate minimal pin for fitgrid 0.4.4
pytest PASS
Note: pinning numpy 1.16.4 also holds zeromq at 4.2.5