kutaslab / fitgrid

Multichannel event-related time-series regression modeling for EEG, MEG, and sensor array data
https://kutaslab.github.io/fitgrid
BSD 3-Clause "New" or "Revised" License
8 stars 4 forks source link

for release 0.4.11 #174

Closed turbach closed 4 years ago

turbach commented 4 years ago

This is a bug fix for #173, summary.py now pulls the time and epoch_id index names from the fitted grid

The fitgrid default epoch_id and time index names are changed to time and epoch_id to align with mkpy and spudtr defaults. This is potentially a breaking change but the defaults are mainly used for generating fake data in the pytests and shouldn't impact model fitting in practice since the epoch_id and time indexes must be set explicitly for fitgrid.lm() and fitgrid.lmer().

codecov[bot] commented 4 years ago

Codecov Report

Merging #174 into master will increase coverage by 0.07%. The diff coverage is 95.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   89.55%   89.63%   +0.07%     
==========================================
  Files          14       14              
  Lines         881      907      +26     
==========================================
+ Hits          789      813      +24     
- Misses         92       94       +2     
Impacted Files Coverage Δ
fitgrid/utils/lm.py 90.08% <80.00%> (-0.99%) :arrow_down:
fitgrid/__init__.py 100.00% <100.00%> (ø)
fitgrid/defaults.py 100.00% <100.00%> (ø)
fitgrid/fake_data.py 100.00% <100.00%> (ø)
fitgrid/utils/summary.py 91.28% <100.00%> (+0.48%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e82ffe7...c666952. Read the comment docs.