kuter007 / android-apktool

Automatically exported from code.google.com/p/android-apktool
Other
0 stars 0 forks source link

XML-Compiler feature missing - surpress overwriting platformBuildVersionName to "APKTOOL" #781

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. decompile apk
2. do your changes
3. recompile apk
4. re-decompile apk again

What is the expected output? What do you see instead?
The original platformBuildVersionName should remain the same.
The platformBuildVersionName is changed to "APKTOOL".

What version of the product are you using? On what operating system?
apktool 2.0.0RC4, Win7Pro and Win8Pro

Please provide any additional information below.
In general that behavior is maybe right/intended but in some cases it is 
required to keep the original values as such (maybe not only the above one but 
also others...???). It would be helpful having a apktool command line switch 
suppressing this substitutions to keep the original values. 

Original issue reported on code.google.com by TheHar...@googlemail.com on 13 Mar 2015 at 7:27

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
BTW: For sure I know the -c switch but that's not a solution because it keeps 
the original xml and NO changes take place!

Original comment by TheHar...@googlemail.com on 13 Mar 2015 at 10:48

GoogleCodeExporter commented 9 years ago
To be honest I only did that change because not touching it caused aapt to fail 
and my background in c++ wasn't strong enough to figure out the alternative of 
leaving the value if one is present or writing it if no value is present.

Then again on the flip side, platformBuildVersion is a value controlled by the 
build system not user. It'll change the value on stock aapt to the version it's 
at. This makes me think it should change it. 

On the flip flip side I understand the importance of not watermarking apktool 
into apk. I'll try and rewrite that to only add if a value isn't present. 

Original comment by connor.tumbleson on 13 Mar 2015 at 2:54