Minor additional functionality

kuthulux / gnome-connection-manager

repository for gnome-connection-manager from kuthulu.com/gcm

Other

68 stars 28 forks source link

Minor additional functionality #29

Closed daradermody closed 4 years ago

daradermody commented 4 years ago

Hey @kuthulux, so happy you updated gnome-connection-manager to work with Ubuntu 19+! Here are some minor improvements I'd love to contribute.

New features

Added 'new local tab' shortcut
Allowed prev/next tab shortcuts to circle around

Minor improvements

Default next/prev tab to CTRL+TAB and CTRL+SHIFT+TAB to be more consistent with other apps
Replaced magic numbers for modifier keys with constants from GTK
Added StartupWMClass to prevent duplicate icons in taskbar

kuthulux commented 4 years ago

Hi Dara thanks a lot for the contribution and pull-request.

I see one typo in your code, the modifier SHIFT is settting the namename = name + "to circleSHIFT+" instead of name = name + "SHIFT+", so shortcuts with shift wont work.

and the shortcut CTRL+N already is mapped to reconnect a console, so maybe reconnect should be changed to CTR+SHIFT+N to leave CTRL+N for the new local shortcut.

kuthulux commented 4 years ago

thanks Dara, pr merged into master branch.