search

kutlugsahin / react-smooth-dnd

react wrapper components for smooth-dnd
MIT License
1.71k stars 142 forks source link

Body classes are not removed on mobile view #67

Open mndzielski opened 3 years ago

mndzielski commented 3 years ago

Hi, I noticed that on mobile view classes added to body tag (smooth-dnd-no-user-select smooth-dnd-disable-touch-action) are still active after drop. This cause that scroll is turned off.

Steps to reproduce on desktop browser (in my case Chrome 85.0.4183.102): 1) Open https://kutlugsahin.github.io/smooth-dnd-demo/ 2) Menu option: Sortable with default options 3) Open dev tools and click "Toggle device toolbar" to mobile 4) Drag and drop any draggable item 5) After drop classes are still presence

image

image

To remove this classes user has to additionally click somewhere on page

RomanChasovitin commented 3 years ago

The same with me, @mndzielski will you fix it?

mndzielski commented 3 years ago

Hi @RomanChasovitin I forked this project and fixed it. You may use my npm package: @mndzielski/react-smooth-dnd I'm afraid that this project is no longer maintain :(

fadijabi commented 1 year ago

@mndzielski/react-smooth-dnd

Thank you for fixing this. I'm using yours now.