search

kutny / tracy-bundle

Tracy PHP debugger bundle for Symfony framework
MIT License
28 stars 5 forks source link

Remove the requirement of email being configured #4

Closed mvrhov closed 10 years ago

kutny commented 10 years ago

Why don't you want email to be required?

mvrhov commented 10 years ago

Because this is forcing me to have email defined in dev environment

kutny commented 10 years ago

But you can set it with

kutny_tracy: emails: []

in config_dev.yml. Do you see any problem with this approach?

mvrhov commented 10 years ago

Other than it looks weird and adds "unnecessary" config setting into the dev?

kutny commented 10 years ago

Well I wanted to make "emails" option mandatory to explicitly tell the bundle user: "Hey, its very important to set this option. If you don't do it, you will not receive notifications about app errors. Don't forget to set it"

If the user does not want to receive notifications, he/she must explicitly set "emails" with an empty array. Yes, most of the bundle users do not want to receive notifications on the dev environment during app development. However setting "emails" with an empty array is so easy, that I really think that it is a "good enough" solution.

mvrhov commented 10 years ago

fair enough