kutsan / zsh-system-clipboard

System clipboard key bindings for Zsh Line Editor with vi mode. It is similar to what `set clipboard=unnamed` does for vim.
GNU General Public License v3.0
140 stars 16 forks source link

Fix logic of wayland if statement #37

Closed dylantjb closed 3 years ago

doronbehar commented 3 years ago

OK I don't understand really what's the issue, but I trust you @b10n and @dylantjb that you use this variable and that this change is needed. @dylantjb please squash the commits and I'll approve the PR.

idest commented 3 years ago

Without this change if wl-copy is installed and $DISPLAY is set, the plugin always skips the _zsh_system_clipboard_set and _zsh_system_clipboard_get assignments, regardless of wheter the environment variable ZSH_SYSTEM_CLIPBOARD_USE_WL_CLIPBOARD is set. With this change the plugin behaves exactly as described in the README.

doronbehar commented 3 years ago

Thanks for the reminder this is still open, I haven't received a notification for the force push.

pbrilius commented 3 years ago

Good insight.